C#: Narrow source model generation. #16873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroduce a new one for ToString.
…ides or implements something.
michaelnebel
force-pushed
the
csharp/narrowsourcegeneration
branch
from
bd896ec
to
e05f835
Compare
michaelnebel
added
the
no-change-note-required
hvitved
previously approved these changes
Jul 11, 2024
csharp/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll
Outdated
Show resolved
Hide resolved
mbg
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we further narrow the C# source model generation to exclude all callables that overrides or implements something else. This is because we need to "limit" the number of generated sources models that could be used during dynamic dispatch (to avoid getting to many false positive/speculative results).